Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ksh #53500

Merged
merged 3 commits into from Jan 6, 2019
Merged

Adding ksh #53500

merged 3 commits into from Jan 6, 2019

Conversation

kaven96
Copy link
Contributor

@kaven96 kaven96 commented Jan 6, 2019

Motivation for this change

There is no ksh, which needed for some commercial software, so I want to add it to the repository. I believe someone will need it too some day.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [+] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [+] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • [+] Fits CONTRIBUTING.md.

pkgs/shells/ksh/default.nix Outdated Show resolved Hide resolved
pkgs/shells/ksh/default.nix Outdated Show resolved Hide resolved
pkgs/shells/ksh/default.nix Outdated Show resolved Hide resolved
pkgs/shells/ksh/default.nix Outdated Show resolved Hide resolved
@joachifm
Copy link
Contributor

joachifm commented Jan 6, 2019

@GrahamcOfBorg build ksh

pkgs/shells/ksh/default.nix Outdated Show resolved Hide resolved
@joachifm joachifm merged commit 5b201a8 into NixOS:master Jan 6, 2019
@joachifm
Copy link
Contributor

joachifm commented Jan 6, 2019

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants