Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linking errors #53490

Merged
merged 53 commits into from Jan 6, 2019
Merged

Fix linking errors #53490

merged 53 commits into from Jan 6, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jan 6, 2019

Motivation for this change

Fixes for #53001

cc @pbogdan @vcunat

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pbogdan
a2jmidid: fix pthread linkage
6edd82d
@pbogdan
aegisub: link with pthread explicitly
4bdf36d
@pbogdan
ahoviewer: link with pthread explicitly
e704063
@pbogdan
airstrike: link with libm explicitly
517f2d3
@pbogdan
dbus_cplusplus: disable tests
d172733 
They fail to build.
@pbogdan
a52dec: build shared libraries
6b0d3da
@pbogdan
artha: fix libgio-2.0 underlinking
9e551ae
@pbogdan
autopanosiftc: fix libm underlinking
8fe36d7
@pbogdan
avogadro: fix libX11 underlinking
ae7557c
@pbogdan
bitmeter: fix libm underlinking
0b04309
@pbogdan
box2d: don't build examples
580125f 
They fail to build and aren't included in the output anyway.
@pbogdan
buddy: link with libm explicitly
b137a4c
@pbogdan
cinepaint: link with lib{m,png} explicitly
e828ad6
@pbogdan
cwiid: link with libbluetooth explicitly
ef5baf8
@pbogdan
dsniff: link with pthreads explicitly
4510ad1
@pbogdan
eboard: link with libdl explicitly
19d339c
@pbogdan
egoboo: link with libm explicitly
69981de
@pbogdan
fileshelter: link with pthreads explicitly
12c733c
@pbogdan
flatpak: link with pthreads explicitly
6910266
@pbogdan
gdmap: link with libm explicitly
2fe11f1
@pbogdan
gitAndTools.svn-all-fast-export: link with libsvn_fs-1 explicitly
4477ded
@pbogdan
globulation2: link with libboost_system explicitly
77b88af
@pbogdan
gnujump: link with libm explicitly
3b49822
@pbogdan
gnuradio: link with pthreads explicitly
8c83c45
@pbogdan
golden-cheetah: link with libz explicitly
12ac71c
@pbogdan
golly-beta: link with lib{dl,GL} explicitly
71f216b
@pbogdan
goxel: link with pthreads explicitly
418a2d7
@pbogdan
gqview: link with libm explicitly
3d94f68
@pbogdan
gtk-server: link with libdl explicitly
46fad2b
@pbogdan
jack_rack: link with pthreads, lib{dl,m} explicitly
0d8bec1
@FRidh
Copy link
Member Author

FRidh commented Jan 6, 2019

Just to check what ofborg has to say about it :)

@vcunat vcunat changed the base branch from staging-next to master January 6, 2019 10:28
@vcunat
Copy link
Member

vcunat commented Jan 6, 2019

In particular I'd be interested in a couple darwin checks from borg.

@vcunat
Copy link
Member

vcunat commented Jan 6, 2019

@GrahamcOfBorg build a52dec avogadro buddy

@vcunat vcunat self-assigned this Jan 6, 2019
@vcunat
Copy link
Member

vcunat commented Jan 6, 2019

I should've looked at Hydra first, I guess.
@GrahamcOfBorg build a52dec
@GrahamcOfBorg build buddy
@GrahamcOfBorg build gitAndTools.svn-all-fast-export

@vcunat vcunat merged commit ac1122f into NixOS:master Jan 6, 2019
vcunat added a commit that referenced this pull request Jan 6, 2019
@vcunat
Merge #53490: fix treewide linking errors after #51770
10a1219 
Issue #53001.  This might not be all of them, but let's not wait.
@pbogdan pbogdan deleted the dt-needed branch December 3, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FRidh @vcunat @GrahamcOfBorg @pbogdan