Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tilix: 1.8.5 -> 1.8.9 #53532

Closed
wants to merge 2 commits into from
Closed

tilix: 1.8.5 -> 1.8.9 #53532

wants to merge 2 commits into from

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Update tilix to its latest version and build with meson. This required me to also bump gtkd.

This currently fails pretty early with

data/meson.build:99:0: ERROR:  Output file name must not contain a subdirectory.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar reviewed Jan 7, 2019
View reviewed changes
pkgs/applications/misc/tilix/default.nix
'';

postInstall = with gnome3; ''
${glib.dev}/bin/glib-compile-schemas $out/share/glib-2.0/schemas

wrapProgram $out/bin/tilix \
--prefix LD_LIBRARY_PATH ":" "${libsecret}/lib"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maebe use gappsWrapperArgs?

pkgs/applications/misc/tilix/no-dub.patch
sources_dir = include_directories('source/')

# Dependencies
-# Note relying on dub to fetch and build dependencies before running meson build is temporary due to a bug in Meson 0.48
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked for clarification about the bug:
gnunn1/tilix@4092dfc#commitcomment-31853141

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't particularly look around to see if there was an issue with this, but I did see improvements for dlang hit in 0.49.0.

@worldofpeace
Copy link
Contributor Author

@jtojnar See anything wrong here https://github.com/gnunn1/tilix/blob/54d37141a75945e291ea3051af9caa7bb943aa40/data/meson.build#L99 ?

@jtojnar
Copy link
Contributor

jtojnar commented Jan 7, 2019 •
edited

Missing install: true? Edit: apparently not needed for configure_file.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 7, 2019

This might be an regression: gnunn1/tilix#1619

@jtojnar
Copy link
Contributor

jtojnar commented Jan 7, 2019 •
edited

Oh right, read the OP. Yeah, that is pretty annoying issue – meson simply does not allow that. I would suggest creating a meson.build file in the dbus dir, or maybe just change the output to @BASENAME@ – it should not matter where it is generated, since we only need it for installation.

@worldofpeace
Copy link
Contributor Author

Oh right, read the OP. Yeah, that is pretty annoying issue – meson simply does not allow that. I would suggest creating a meson.build file in the dbus dir, or maybe just change the output to @BASENAME@ – it should not matter where it is generated, since we only need it for installation.

Thanks, I'll try that 👍

@worldofpeace
Copy link
Contributor Author

Hmm I guess it really must be broken judging from the build failure

tilix@exe/source_gx_i18n_l10n.d.o: In function `_D2gx4i18n4l10n1_FAyaZQe':
../source/gx/i18n/l10n.d:(.text._D2gx4i18n4l10n1_FAyaZQe[_D2gx4i18n4l10n1_FAyaZQe]+0x42): undefined reference to `_D4glib3StrQe9toStringzFNaAyaZPa'
../source/gx/i18n/l10n.d:(.text._D2gx4i18n4l10n1_FAyaZQe[_D2gx4i18n4l10n1_FAyaZQe]+0x56): undefined reference to `_D4glib3StrQe9toStringzFNaAyaZPa'
../source/gx/i18n/l10n.d:(.text._D2gx4i18n4l10n1_FAyaZQe[_D2gx4i18n4l10n1_FAyaZQe]+0x64): undefined reference to `c_g_dgettext'
../source/gx/i18n/l10n.d:(.text._D2gx4i18n4l10n1_FAyaZQe[_D2gx4i18n4l10n1_FAyaZQe]+0x71): undefined reference to `_D4glib3StrQe8toStringFNaPxamZAya'
tilix@exe/source_gx_i18n_l10n.d.o: In function `_D2gx4i18n4l10n2C_FAyaQdZQg':
../source/gx/i18n/l10n.d:(.text._D2gx4i18n4l10n2C_FAyaQdZQg[_D2gx4i18n4l10n2C_FAyaQdZQg]+0x5a): undefined reference to `_D4glib3StrQe9toStringzFNaAyaZPa'
../source/gx/i18n/l10n.d:(.text._D2gx4i18n4l10n2C_FAyaQdZQg[_D2gx4i18n4l10n2C_FAyaQdZQg]+0x6e): undefined reference to `_D4glib3StrQe9toStringzFNaAyaZPa'
../source/gx/i18n/l10n.d:(.text._D2gx4i18n4l10n2C_FAyaQdZQg[_D2gx4i18n4l10n2C_FAyaQdZQg]+0x82): undefined reference to `_D4glib3StrQe9toStringzFNaAyaZPa'
../source/gx/i18n/l10n.d:(.text._D2gx4i18n4l10n2C_FAyaQdZQg[_D2gx4i18n4l10n2C_FAyaQdZQg]+0x94): undefined reference to `c_g_dpgettext2'
../source/gx/i18n/l10n.d:(.text._D2gx4i18n4l10n2C_FAyaQdZQg[_D2gx4i18n4l10n2C_FAyaQdZQg]+0xa1): undefined reference to `_D4glib3StrQe8toStringFNaPxamZAya'
collect2: error: ld returned 1 exit status
Error: linker exited with status 1
ninja: build stopped: subcommand failed.
builder for '/nix/store/07ngw7s8bqlm6vgm5z1fhfsrdw0v70m8-tilix-1.8.9.drv' failed with exit code 1
error: build of '/nix/store/07ngw7s8bqlm6vgm5z1fhfsrdw0v70m8-tilix-1.8.9.drv' failed

@jtojnar
Copy link
Contributor

jtojnar commented Jan 8, 2019 •
edited

Looks like glib is not linked, try adding dependency('glib-2.0') to https://github.com/gnunn1/tilix/blob/a6ea2cb08481710218de06bb55cc5d03ad3e1476/meson.build#L113

@worldofpeace
Copy link
Contributor Author

Looks like glib is not linked, try adding dependency('glib-2.0') to https://github.com/gnunn1/tilix/blob/a6ea2cb08481710218de06bb55cc5d03ad3e1476/meson.build#L113

Same errors

@worldofpeace worldofpeace mentioned this pull request Jan 18, 2019
Merged
@worldofpeace
Copy link
Contributor Author

Decided to switch to meson later in d4224f0, though I'd really like to put together an issue for meson as to why this isn't working.

worldofpeace added a commit that referenced this pull request Jan 25, 2019
@worldofpeace
tilix: 1.8.5 -> 1.8.9, cleanup
d4224f0 
Decided to be more juidical than #53532 as switching to meson
isn't currently working out.
danbst pushed a commit to danbst/nixpkgs that referenced this pull request Jan 31, 2019
@worldofpeace @danbst
tilix: 1.8.5 -> 1.8.9, cleanup
14ce11b 
Decided to be more juidical than NixOS#53532 as switching to meson
isn't currently working out.
@worldofpeace worldofpeace deleted the tilix/1.8.9 branch March 18, 2019 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @jtojnar @GrahamcOfBorg