-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tilix: 1.8.5 -> 1.8.9 #53532
tilix: 1.8.5 -> 1.8.9 #53532
Conversation
Also build with meson
''; | ||
|
||
postInstall = with gnome3; '' | ||
${glib.dev}/bin/glib-compile-schemas $out/share/glib-2.0/schemas | ||
|
||
wrapProgram $out/bin/tilix \ | ||
--prefix LD_LIBRARY_PATH ":" "${libsecret}/lib" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maebe use gappsWrapperArgs
?
sources_dir = include_directories('source/') | ||
|
||
# Dependencies | ||
-# Note relying on dub to fetch and build dependencies before running meson build is temporary due to a bug in Meson 0.48 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked for clarification about the bug:
gnunn1/tilix@4092dfc#commitcomment-31853141
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't particularly look around to see if there was an issue with this, but I did see improvements for dlang hit in 0.49.0.
@jtojnar See anything wrong here https://github.com/gnunn1/tilix/blob/54d37141a75945e291ea3051af9caa7bb943aa40/data/meson.build#L99 ? |
|
This might be an regression: gnunn1/tilix#1619 |
Oh right, read the OP. Yeah, that is pretty annoying issue – meson simply does not allow that. I would suggest creating a |
Thanks, I'll try that 👍 |
Hmm I guess it really must be broken judging from the build failure
|
Looks like glib is not linked, try adding |
Same errors |
Decided to switch to meson later in d4224f0, though I'd really like to put together an issue for meson as to why this isn't working. |
Decided to be more juidical than #53532 as switching to meson isn't currently working out.
Decided to be more juidical than NixOS#53532 as switching to meson isn't currently working out.
Motivation for this change
Update
tilix
to its latest version and build with meson. This required me to also bumpgtkd
.This currently fails pretty early with
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)