Feature #4115: default company colour setting #6998
Conversation
Works only in single player.
|
Seems to work as intended, also in multiplayer games. In multiplayer, if two players have the same preferred company colour, the second to create their company just gets assigned a different colour. Tentatively approving this, but I'd like someone else to review the UI placement and strings too, I'm not entirely sure I like it. |
|
I'll review the UI and strings. |
|
UI is fine. Strings, we could argue back and forth about 'Starting company colour' vs 'Default company colour'. I think 'Default company colour' is a little better, but it's pretty much potato / potato. |
| @@ -1258,6 +1259,9 @@ STR_CONFIG_SETTING_DYNAMIC_ENGINES_EXISTING_VEHICLES :{WHITE}Changing | |||
| STR_CONFIG_SETTING_INFRASTRUCTURE_MAINTENANCE :Infrastructure maintenance: {STRING2} | |||
| STR_CONFIG_SETTING_INFRASTRUCTURE_MAINTENANCE_HELPTEXT :When enabled, infrastructure causes maintenance costs. The cost grows over-proportional with the network size, thus affecting bigger companies more than smaller ones | |||
|
|
|||
| STR_CONFIG_SETTING_COMPANY_STARTING_COLOUR :Starting company colour: {STRING2} | |||
There was a problem hiding this comment.
My comment feels a bit like bike shedding, yet: AI also start with a company colour. Maybe "Default company colour" with a help text of "Choose a company colour the player starts with by default" would make it ever so slightly clearer?
There was a problem hiding this comment.
Yes, it sound better, I will change it. It is always hard to make a short and clear description, so thanks for the help.
In this case I think I should put in a check before assigning the colour, as I don't know at what point the color changing fails, and some variable values might be different for server and client. |
I don't see a problem there. The 2nd player simply gets another colour... whichever of two that is. In multiplayer the order of who is first will be determine by the server and is unique.
I don't think so. There always is first a player company. |
|
Nvm my comment from yesterday. Andy is right - we can always change the wording of strings later if we feel like it. |
Works only in single player.
Works only in single player.