linux: flag to indicate 32bit emulation support #53511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Naming nitpick: it could be confused with something else – a kinda hybrid between 32-bit and 64-bit x86. That one seems to be slowly dying, but still... |
Motivated by the need to warn users trying to build configurations that depend on being able to run 32bit apps on 64bit kernels.
joachifm
force-pushed
the
kernel-32bit-emu-feature-flag
branch
from
8366e2e
to
ab070d1
Compare
joachifm
changed the title
|
Good point. I've changed the name to make it clearer. |
matthewbauer
reviewed
Jan 7, 2019
| @@ -14825,6 +14825,7 @@ in | |||
|
|
|||
| # Hardened linux | |||
| hardenedLinuxPackagesFor = kernel: linuxPackagesFor (kernel.override { | |||
| features.ia32Emulation = false; | |||
There was a problem hiding this comment.
I think we should keep the original naming of IA32_EMULATION to reduce need for additional documentation. Ideally we could just look directly. This is partially done in #42838.
|
I also tried |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily to avoid problems exemplified by #51097