Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3c832ac5dda0
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 591da7cb8480
Choose a head ref
  • 3 commits
  • 4 files changed
  • 3 contributors

Commits on Jan 5, 2019

  1. haskell-modules: add callCabal2nixWithOptions.

    Fixes #44377.
    
    (cherry picked from commit 4abb8be)
    dhess authored and luigy committed Jan 5, 2019
    Copy the full SHA
    326104e View commit details

Commits on Jan 6, 2019

  1. Merge pull request #53431 from obsidiansystems/callCaball2nixWithOpti…

    …on-18.09
    
    [18.09] backport haskell-modules: add callCabal2nixWithOptions
    basvandijk authored Jan 6, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    64e1f4b View commit details
  2. wsjtx: 1.9.1 -> 2.0.0

    Old version of FT8 protocol was obsoleted on 2019-01-01.
    
    (cherry picked from commit fada704)
    lasandell authored and markuskowa committed Jan 6, 2019
    Copy the full SHA
    591da7c View commit details
13 changes: 8 additions & 5 deletions pkgs/applications/misc/wsjtx/default.nix
Original file line number Diff line number Diff line change
@@ -4,12 +4,12 @@

stdenv.mkDerivation rec {
name = "wsjtx-${version}";
version = "1.9.1";
version = "2.0.0";

# This is a composite source tarball containing both wsjtx and a hamlib fork
# This is a "superbuild" tarball containing both wsjtx and a hamlib fork
src = fetchurl {
url = "http://physics.princeton.edu/pulsar/K1JT/wsjtx-${version}.tgz";
sha256 = "143r17fri08mwz28g17wcfxy60h3xgfk46mln5lmdr9k6355aqqc";
url = "http://physics.princeton.edu/pulsar/k1jt/wsjtx-${version}.tgz";
sha256 = "66434f69f256742da1fe057ec51e4464cab2614f0bfb1a310c04a385b77bd014";
};

# Hamlib builds with autotools, wsjtx builds with cmake
@@ -20,7 +20,10 @@ stdenv.mkDerivation rec {
];
buildInputs = [ fftw fftwFloat libusb1 qtbase qtmultimedia qtserialport ];

# Composite build has its own patch step after it extracts the inner archives
# Remove Git dependency from superbuild since sources are included
patches = [ ./super.patch ];

# Superbuild has its own patch step after it extracts the inner archives
postPatch = "cp ${./wsjtx.patch} wsjtx.patch";

meta = with stdenv.lib; {
12 changes: 12 additions & 0 deletions pkgs/applications/misc/wsjtx/super.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 3bf97a4..2c9dce5 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -23,7 +23,6 @@ source tarball." )
#
# Find_library (USB_LIBRARY NAMES libusb.a usb)
Find_program (PATCH_EXECUTABLE patch REQUIRED)
-Find_package (Git REQUIRED)

#
# extra C flags to minimize hamlib excutable sizes
12 changes: 6 additions & 6 deletions pkgs/applications/misc/wsjtx/wsjtx.patch
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
Index: wsjtx/CMakeLists.txt
===================================================================
--- wsjtx/CMakeLists.txt (revision 8382)
+++ wsjtx/CMakeLists.txt (working copy)
@@ -866,6 +866,7 @@
find_package (Qt5Widgets 5 REQUIRED)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 3e7e816b..e7dbb14a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -860,6 +860,7 @@ find_package (Qt5Widgets 5 REQUIRED)
find_package (Qt5Multimedia 5 REQUIRED)
find_package (Qt5PrintSupport 5 REQUIRED)
find_package (Qt5Sql 5 REQUIRED)
+find_package (Qt5SerialPort 5 REQUIRED)

if (WIN32)
29 changes: 16 additions & 13 deletions pkgs/development/haskell-modules/make-package-set.nix
Original file line number Diff line number Diff line change
@@ -176,19 +176,22 @@ in package-set { inherit pkgs stdenv callPackage; } self // {
callHackage = name: version: callPackageKeepDeriver (self.hackage2nix name version);

# Creates a Haskell package from a source package by calling cabal2nix on the source.
callCabal2nix = name: src: args: let
filter = path: type:
pkgs.lib.hasSuffix "${name}.cabal" path ||
baseNameOf path == "package.yaml";
expr = self.haskellSrc2nix {
inherit name;
src = if pkgs.lib.canCleanSource src
then pkgs.lib.cleanSourceWith { inherit src filter; }
else src;
};
in overrideCabal (callPackageKeepDeriver expr args) (orig: {
inherit src;
});
callCabal2nixWithOptions = name: src: extraCabal2nixOptions: args:
let
filter = path: type:
pkgs.lib.hasSuffix "${name}.cabal" path ||
baseNameOf path == "package.yaml";
expr = self.haskellSrc2nix {
inherit name extraCabal2nixOptions;
src = if pkgs.lib.canCleanSource src
then pkgs.lib.cleanSourceWith { inherit src filter; }
else src;
};
in overrideCabal (callPackageKeepDeriver expr args) (orig: {
inherit src;
});

callCabal2nix = name: src: args: self.callCabal2nixWithOptions name src "" args;

# : { root : Path
# , name : Defaulted String