Handle plus without shift in ConsoleUI #2634
Merged
+26
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Easy
politas
added a commit
that referenced
this pull request
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Germans can't install mods in ConsoleUI, because their '+' key doesn't work.
Cause
ConsoleUI was developed under the QWERTY keyboard layout, where '+' is typed by pressing Shift-equals, and Windows reports this with the Shift modifier (Mono reports it without the modifier, so there was already a workaround for that).
However in a QWERTZ layout, '+' is an unshifted key, so it doesn't match the
ConsoleKeyInfoobject we used for key bindings.Changes
Now we represent Plus as an array of two
ConsoleKeyInfoobjects, one with Shift and one without, to cover both cases. The framework is updated to allowIEnumerable<ConsoleKeyInfo>to be passed toAddBinding, so existing usages ofKeys.Pluswill work as-is.Fixes #2633 (the part that can be fixed).