Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmuxp: 1.4.2 -> 1.5.0a1 #53505

Merged
merged 3 commits into from Jan 24, 2019
Merged

tmuxp: 1.4.2 -> 1.5.0a1 #53505

merged 3 commits into from Jan 24, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 6, 2019

Motivation for this change

Fixes #53492

cc: @etu

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner January 6, 2019 16:37
@etu
Copy link
Contributor

etu commented Jan 6, 2019

Triggering the build since macOS seems to be allowed for this package now.

@GrahamcOfBorg build tmuxp

etu
etu approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work

@lheckemann lheckemann merged commit f936504 into NixOS:master Jan 24, 2019
@marsam marsam deleted the update-tmuxp branch January 24, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jgeerds jgeerds Awaiting requested review from jgeerds

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @etu @lheckemann @GrahamcOfBorg