Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce namespace migration and do fixes #56

Closed
wants to merge 3 commits into from
Closed

introduce namespace migration and do fixes #56

wants to merge 3 commits into from

Conversation

The-Voidwalker
Copy link
Member

@The-Voidwalker The-Voidwalker commented Jan 7, 2019 •
edited

This should introduce:

  • Namespace deletion
  • Namespace renaming (because this didn't work before)
  • Namespace migration (handles conflicts in page titles and moving entire namespaces around)

This fixes:

  • Default edit restriction is set to the permission "none" (Example)
  • The error produced by T3963
  • An issue created by $htmlForm being false in SpecialManageWikiNamespaces.php
  • Any page becoming inaccessible when a namespace is added or modified

@JohnFLewis
Copy link
Contributor

In general okay besides missing i18n and the changes to $existingNamespace - you want to query by name not ID.

@The-Voidwalker
Copy link
Member Author

@JohnFLewis I changed the call to function submitForm() so that it passes on the ID in the form of $special (L272), as, if the user changes the name of the namespace, it will treat it like they are adding a new namespace instead of renaming the old one. But, looking back at the code, I'm surprised I didn't get a fatal when testing.

@paladox
Copy link
Contributor

paladox commented Jan 7, 2019

https://gerrithub.io/c/miraheze/ManageWiki/+/10

https://gerrithub.io/c/miraheze/ManageWiki/+/11

https://gerrithub.io/c/miraheze/ManageWiki/+/12

I've imported the pull into GerritHub

@paladox
Copy link
Contributor

paladox commented Jan 7, 2019

merged on gerrithub.

@paladox paladox closed this Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paladox paladox paladox left review comments

@JohnFLewis JohnFLewis Awaiting requested review from JohnFLewis

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@The-Voidwalker @JohnFLewis @paladox