Maintainer tag #307
Merged
Maintainer tag #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackages If the author of the PR is one of any number of maintainers, add the label. This is in contrast to the previous version, where the submitter of the PR had to be the ONLY maintainer on ANY package they touched.
|
Does ofBorg receive approval notifications from GitHub? (asking about feasibility of approved-by:maintainer tag; maybe even approved-by:some-maintainer and approved-by:all-maintainers) |
|
It does! https://developer.github.com/v3/activity/events/types/#pullrequestreviewevent next step :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the by-maintainer label when the PR is by the maintainer.
If the PR affects a package with multiple maintainers, it will not be labeled as by the maintainer. (TODO?)If the author of the PR is one of any number of maintainers, add the
label. This is in contrast to the previous version, where the submitter
of the PR had to be the ONLY maintainer on ANY package they touched.