Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer reports success even if not all files were copied #6884

Closed
nielsmh opened this issue Aug 13, 2018 · 2 comments · Fixed by #7270
Closed

Installer reports success even if not all files were copied #6884

nielsmh opened this issue Aug 13, 2018 · 2 comments · Fixed by #7270
Labels
bug Something isn't working OS: Windows This issue is related to a MS Windows problem

Comments

@nielsmh
Copy link
Contributor

nielsmh commented Aug 13, 2018

Per this forum topic: https://www.tt-forums.net/viewtopic.php?f=31&t=83038

The Windows installation program will pretend to complete installation, and report success, even if some core files are locked and cannot be overwritten. For example, if the game is running while attempting to install a newer version over it, parts of the running game will be overwritten, but not the main EXE file.

If writing any file during installation fails, the installer should probably stop and request that the user attempts to remedy the locked file/out of disk space/whatever situation. Ideally, before starting installation it should try to open any existing OpenTTD.exe file for writing in the destination, and if it fails, warn the user beforehand to exit the game.
@nielsmh nielsmh added the OS: Windows This issue is related to a MS Windows problem label Aug 13, 2018
@TrueBrain TrueBrain added the bug Something isn't working label Aug 25, 2018
@stale
Copy link

stale bot commented Jan 24, 2019

This issue has been automatically marked as stale because it has not had any activity in the last two months.
If you believe the issue is still relevant, please test on the latest nightly and report back.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale Stale issues label Jan 24, 2019
@LordAro LordAro added good first issue Good for newcomers and removed stale Stale issues labels Jan 24, 2019
@TrueBrain
Copy link
Member

Clearly the NSIS is misconfigured :D This will be fixed with #7270. I suggest we do not spend any additional time on it, till that lands :D

@TrueBrain TrueBrain added pinned and removed good first issue Good for newcomers labels Apr 2, 2019
@TrueBrain TrueBrain mentioned this issue Apr 2, 2019
Merged
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working OS: Windows This issue is related to a MS Windows problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce CMake (and removing all other project-related code) TrueBrain/OpenTTD
3 participants
@nielsmh @TrueBrain @LordAro