Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security Update: pythonPackages.python-gnupg: 0.4.3 -> 0.4.4 #54553

Merged
merged 2 commits into from Jan 25, 2019
Merged

Security Update: pythonPackages.python-gnupg: 0.4.3 -> 0.4.4 #54553

merged 2 commits into from Jan 25, 2019

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Jan 24, 2019 •
edited

Motivation for this change

Fixes CVE-2019-6690

https://blog.hackeriet.no/cve-2019-6690-python-gnupg-vulnerability/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp stigtsp requested a review from FRidh as a code owner January 24, 2019 21:13
@stigtsp stigtsp changed the title pythonPackages.python-gnupg: 0.4.3 -> 0.4.4 Security Update: pythonPackages.python-gnupg: 0.4.3 -> 0.4.4 Jan 24, 2019
dotlambda
dotlambda requested changes Jan 24, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention the fixed vuln (+ link) in the commit description.

pkgs/development/python-modules/python-gnupg/default.nix Outdated Show resolved Hide resolved
@stigtsp
Copy link
Member Author

stigtsp commented Jan 24, 2019

Please mention the fixed vuln (+ link) in the commit description.

Sure. Would you like a single squashed commit?

@dotlambda
Copy link
Member

Actually, I think the update and the improvements should be two separate commits so that we can backport only one of them.

@stigtsp
Copy link
Member Author

stigtsp commented Jan 24, 2019

Actually, I think the update and the improvements should be two separate commits so that we can backport only one of them.

Done

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.python-gnupg python3.pkgs.python-gnupg

@dotlambda dotlambda merged commit ba9d958 into NixOS:master Jan 25, 2019
@dotlambda
Copy link
Member

Thanks a lot!

@dotlambda
Copy link
Member

Backported in 119a931.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

@copumpkin copumpkin Awaiting requested review from copumpkin

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stigtsp @dotlambda @GrahamcOfBorg