-
-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #7088: close AI/GS textfile window when their data are invalid #7094
Fix #7088: close AI/GS textfile window when their data are invalid #7094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of this solution, it's too brittle. The issue boils down to the Window trying to maintain something consistent when the underlying state (the slot) changes.
Instead, the window should "save" the ScriptConfig object (GetConfig(slot)
) in its constructor, and just refer to that from then on. Should help to fix a couple of the other recent issues (#7090, #7091) as well, I think...
I added a solution based on |
cbef522
to
7cd6d41
Compare
This pull request has been automatically marked as stale because it has not had any activity in the last month. |
7cd6d41
to
267a6ff
Compare
267a6ff
to
7a2c654
Compare
For some reason, this fix stopped working properly. :( EDIT: fixed it. |
7a2c654
to
3202db5
Compare
4477d17
to
08ecbf1
Compare
This pull request has been automatically marked as stale because it has not had any activity in the last month. |
Stale. Closing, thanks. |
ping for review |
08ecbf1
to
3398ff6
Compare
3398ff6
to
1426f45
Compare
1426f45
to
3761d8f
Compare
3761d8f
to
503c63c
Compare
… displaying a textfile