Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove duplicate French and Slovak town names #7085

Merged
merged 1 commit into from Jan 24, 2019

Conversation

nikolas
Copy link
Member

@nikolas nikolas commented Jan 22, 2019

I've replaced some of the duplicate real town names with new real town
names in the French and Slovak sets.

Also, some Slovak town names were missing accents, so I've fixed those.

src/table/townname.h Outdated Show resolved Hide resolved
I've replaced some of the duplicate real town names with new real town
names in the French and Slovak sets.

Also, some Slovak town names were missing accents, so I've fixed those.
Copy link
Contributor

@planetmaker planetmaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't exactly judge the correctness of the accents in Romanian... but yes!

@nikolas
Copy link
Member Author

nikolas commented Jan 24, 2019

I'm not the most familiar with these town names either - the Slovak corrections are based on info found here: https://en.wikipedia.org/wiki/List_of_cities_and_towns_in_Slovakia

@LordAro LordAro dismissed their stale review January 24, 2019 21:46

i thought outdated reviews were automatically dismissed?

@LordAro LordAro merged commit 4158c07 into OpenTTD:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants