Darwin staging branch #53230
Closed
Darwin staging branch #53230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
6.topic: darwin
This reverts commit 98101b5.
fixes some issues in my commits in: - basic_cmds - network_cmds
On macOS, the drivers output will be empty. Perhaps? we should just leave it out, but for now it is just an empty directory.
Not needed with clock_gettime available to us.
AudioUnit now depends on AudioToolbox, changing the original behavior where AudioToolbox depends on AudioUnit.
This appears to be missing in the latest xnu updates. Not sure why the Makefile is not installing it correctly. A simple install command will get it for us though.
matthewbauer
force-pushed
the
darwin-staging
branch
from
da3ae97
to
52af592
Compare
LnL7
reviewed
Jan 8, 2019
| @@ -82,9 +82,7 @@ with frameworks; with libs; { | |||
| PCSC = [ CoreData ]; | |||
| PreferencePanes = []; | |||
| PubSub = []; | |||
| QTKit = [ CoreMediaIO CoreMedia MediaToolbox QuickTime VideoToolbox ]; | |||
There was a problem hiding this comment.
Why did you remove a bunch of these? They are still in the SDK.
There was a problem hiding this comment.
Are you sure? Maybe they’re in another download. I’ll find the the error i was getting...
There was a problem hiding this comment.
I looked at darwin.apple_sdk.sdk which is the source IIRC.
There was a problem hiding this comment.
Maybe just quicktime was removed?
There was a problem hiding this comment.
Ah indeed, the QuickTime headers are no longer there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some commits on top of staging-next branch to fix issues with my #47678 pr.