Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weechat-matrix-bridge: 2018-05-29 -> 2018-11-19 #53196

Merged
merged 1 commit into from Jan 14, 2019
Merged

weechat-matrix-bridge: 2018-05-29 -> 2018-11-19 #53196

merged 1 commit into from Jan 14, 2019

Conversation

ptman
Copy link
Contributor

@ptman ptman commented Jan 2, 2019

Motivation for this change

Updated the package to get upstream fix for HTTP/2 proxies which was affecting me. I think this would be a good candidate for backporting to release-18.09 (?), as it's a leaf package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 14, 2019 •
edited

Besides encryption that doesn't work, but possibly never did, everything seems ok.

lua: unable to execute file "/home/rnhmjoj/.weechat/lua/autoload/olm.lua"
lua: error: error loading module 'ffi' from file '/nix/store/7g8k05a4i001hkyfxl5dav1mr3kd2lma-weechat-matrix-bridge-2018-11-19/lib/ffi.so':
/nix/store/7g8k05a4i001hkyfxl5dav1mr3kd2lma-weechat-matrix-bridge-2018-11-19/lib/ffi.so: undefined symbol: lua_tointeger
matrix: Unable to load olm encryption library. Not enabling encryption. Please see documentation (README.md) for information on how to enable

@Mic92 Mic92 merged commit 04f6a6b into NixOS:master Jan 14, 2019
@Mic92
Copy link
Member

Mic92 commented Jan 14, 2019

I think encryption was broken for a long time.

@ptman
Copy link
Contributor Author

ptman commented Jan 15, 2019

@Mic92 @rnhmjoj yes, exactly, the weechat-script only has support for the older "olm" encryption, while all modern matrix clients use the newer "megolm" protocol

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 15, 2019

Oh, right. Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ptman @rnhmjoj @Mic92 @GrahamcOfBorg @Janik-Haag