libvirt: support proper networking in user session #53204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhoeg
force-pushed
the
m/libvirt
branch
2 times, most recently
from
5582c46
to
05df6a7
Compare
|
Thanks @volth - how about this version? |
peterhoeg
changed the title
peterhoeg
changed the title
|
Any reservations @infinisil ? |
infinisil
reviewed
Jan 23, 2019
| environment = { | ||
| # this file is expected in /etc/qemu and not sysconfdir (/var/lib) | ||
| etc."qemu/bridge.conf".text = (lib.concatStringsSep "\n" (map (e: | ||
| "allow ${e}") cfg.allowedBridges)); |
There was a problem hiding this comment.
{
etc."qemu/bridge.conf".text = lib.concatMapStringsSep "\n" (e: "allow ${e}") cfg.allowedBridges;
}
Description updated. Any other concerns or are we good to go? If you want the module fine-tuned, can we at least merge the change to derivation? I've been carrying this change on my side for a while and it causes a bunch of stuff to be rebuilt instead of just fetching from the cache. |
|
As I haven't heard any strong reservations, I'm taking the liberty of merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
With the help of
qemu-bridge-helperit's possible for VMs run underqemu:///sessionto have proper network access and not resort to user mode networking.In my case that means I can dump VirtualBox!
I am not sure ifWe are using"QEMU_PR_HELPER=/run/current-system/sw/bin/qemu-pr-helper"is really the best way to pass in the path to the PR helper but since the qemu package to use is configurable, we need a global path.QEMU_PR_HELPER=/run/libvirt/nix-helpers/qemu-pr-helperbased on @volth's feedback.Cc: @fpletz
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)