vlc: add protobuf for chromecast support! #53184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I think this might depend on #53164 , whoops sorry. |
Mic92
reviewed
Jan 2, 2019
| @@ -39,7 +40,7 @@ stdenv.mkDerivation rec { | |||
| libkate libtiger libv4l samba liboggz libass libdvbpsi libva | |||
| xorg.xlibsWrapper xorg.libXv xorg.libXvMC xorg.libXpm xorg.xcbutilkeysyms | |||
| libdc1394 libraw1394 libopus libebml libmatroska libvdpau libsamplerate | |||
| fluidsynth wayland wayland-protocols | |||
| fluidsynth wayland wayland-protocols protobuf | |||
There was a problem hiding this comment.
nativeBuildInputs maybe because protoc is executed at build time?
There was a problem hiding this comment.
Good idea, unsure. It does retain a dep via libtool files it looks like?
$ PAGER= nix why-depends -f . vlc protobuf --all 14:33:09 on 19-01-02
/nix/store/a7y3ssv1dmv4dhv2qjxczybjr3ia1ds0-vlc-3.0.5
╚═══lib/vlc/plugins/stream_out/libstream_out_chromecast_plugin.la: … -lpthread -lsystemd /nix/store/bscqmp3iisv2liwa7gdrnvs9paixak6a-protobuf-3.6.1/lib/libprotobuf-…
lib/vlc/plugins/stream_out/libstream_out_chromecast_plugin.so: …dbus-1.12.12-lib/lib:/nix/store/bscqmp3iisv2liwa7gdrnvs9paixak6a-protobuf-3.6.1/lib:/nix/store/b…
=> /nix/store/bscqmp3iisv2liwa7gdrnvs9paixak6a-protobuf-3.6.1
There was a problem hiding this comment.
ok. Probably it would be both in the cross-compiling case then.
I'd just cherry-pick it here. |
10 tasks
|
This seems to be superseded by #58588. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Easy dependency and now I can use vlc to cast media! \o/
Some caveats:
but I haven't chased that down re:config or if it varies.
Instead you can specify via argument like so:
(or nvlc or w/e, and actual IP)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)