Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vagrant: Add vagrant-libvirt utility dependencies #53182

Merged
merged 1 commit into from Feb 8, 2019
Merged

vagrant: Add vagrant-libvirt utility dependencies #53182

merged 1 commit into from Feb 8, 2019

Conversation

ryanfitzsimon
Copy link
Contributor

Motivation for this change

When using vagrant-libvirt as provider, the 'vagrant package' command requires 'qemu-img' and 'virt-sysprep'.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryanfitzsimon
vagrant: Add vagrant-libvirt utility dependencies
b66b0c5 
When using vagrant-libvirt as provider, the 'vagrant package'
command requires 'qemu-img' and 'virt-sysprep'.
@ryanfitzsimon
Copy link
Contributor Author

@mat8913, @calbrecht, @globin does this look ok to you?

mat8913
mat8913 approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@mat8913 mat8913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems with it

calbrecht
calbrecht approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@calbrecht calbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matthewbauer matthewbauer merged commit 0dd7732 into NixOS:master Feb 8, 2019
@ryanfitzsimon ryanfitzsimon deleted the vagrant-libvirt-utils branch February 12, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calbrecht calbrecht calbrecht approved these changes

@mat8913 mat8913 mat8913 approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ryanfitzsimon @calbrecht @mat8913 @matthewbauer @GrahamcOfBorg @Janik-Haag