Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pango: 1.42.4 -> 1.43.0 #53181

Closed
wants to merge 2 commits into from
Closed

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 2, 2019

  • use meson, fix build (required now)

  • Add flag to enable doc building to match
    previous behavior and particularly ensure
    output 'devdoc' is created/used :).

  • patch from upstream commit to fix linking

Motivation for this change

http://ftp.gnome.org/pub/GNOME/sources/pango/1.43/pango-1.43.0.news

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Been using this on my system, so at least works that well :).

* use meson, fix build (required now)

* Add flag to enable doc building to match
  previous behavior and particularly ensure
  output 'devdoc' is created/used :).

* patch from upstream commit to fix linking
@vcunat
Copy link
Member

vcunat commented Jan 2, 2019

I think pango follows the GNOME's even-odd numbering, i.e. 1.43.x wouldn't be meant for general usage. EDIT: version info in repology agrees with me (green is the latest stable seen).

@jtojnar
Copy link
Contributor

jtojnar commented Jan 2, 2019

I agree. Sometimes we do use unstable versions – for example, when it brings such important feature as colour emoji and is stable enough. But in this case there are still some bugs from meson translation and no obvious benefit. For instance, it seems pc files’ Requires key are different; we might need to re-evaluate propagatedBuildInputs.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 2, 2019 via email

@dtzWill dtzWill closed this Jan 2, 2019
@vcunat
Copy link
Member

vcunat commented Jan 2, 2019

We could add a comment near its version, if you find it surprising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants