mesa: 18.1.7 -> 18.3.1 [backport] #53218
Closed
+148
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueldr
previously requested changes
Jan 13, 2019
| @@ -89,29 +93,22 @@ let self = stdenv.mkDerivation { | |||
| ./symlink-drivers.patch | |||
| ./missing-includes.patch # dev_t needs sys/stat.h, time_t needs time.h, etc.-- fixes build w/musl | |||
| ./disk_cache-include-dri-driver-path-in-cache-key.patch | |||
| ]; | |||
| ] ++ lib.optional stdenv.isDarwin ./darwin-clock-gettime.patch; | |||
There was a problem hiding this comment.
The file is missing, which caused the ofborg eval failure.
|
Oops, this seems really dry as a review... Let's add some words. Hi! Thanks for the backport, let's fix the basic issues and then look at whether it's right or not as a backport. |
|
Hmm, right, it probably is a bit more risky than what we usually pick. |
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libdrm/versions (cherry picked from commit fe667c9d63a1dbc82e4b58b64d7dc64b4e6410c5) Reason: needed to update mesa
rnhmjoj
force-pushed
the
release-18.09
branch
from
615dde9 to
66af172
Compare
GrahamcOfBorg
added
8.has: clean-up
8.has: package (new)
|
I'm thinking of the option to provide newer mesa drivers as a non-default option. (libdrm bump itself probably isn't risky) |
|
I'm closing this since we now have mesa 18.3.4 in release-19.03. |
|
Well, 18.09 will be alive for several weeks at least, but there's probably not enough motivation to get this inside... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
18.3.1 brings openGL 4.5 compatibility profile to the radeonsi and 4.3 to virgl besides many bugfixes.
I don't know if this is allowed to be backported since it's a major update and could potentially break stuff. Anyway, I have been running this on my system for a couple of weeks with no issues.
Things done
sandboxinnix.confon non-NixOS)