Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tdrop: init at 2018-11-13 #53215

Merged
merged 1 commit into from Jan 18, 2019
Merged

tdrop: init at 2018-11-13 #53215

merged 1 commit into from Jan 18, 2019

Conversation

wedens
Copy link

@wedens wedens commented Jan 2, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wedens
Copy link
Author

wedens commented Jan 3, 2019

@worldofpeace I've applied your suggestions. Thanks.

@worldofpeace
Copy link
Contributor

@wedens Also change the version in your commit msg 😄

@wedens wedens changed the title tdrop: init at 2019-01-02 tdrop: init at 2018-11-13 Jan 3, 2019
@wedens
Copy link
Author

wedens commented Jan 3, 2019

Done 🙂

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, executed and I can see the help menu. Though I haven't tested if it functions properly.

@dywedir
Copy link
Member

dywedir commented Jan 18, 2019

Thanks!

@dywedir dywedir merged commit 1221fc7 into NixOS:master Jan 18, 2019
@wedens wedens deleted the tdrop-init branch January 28, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants