Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv/native: add missing argument to fix build failure #53219

Merged
merged 1 commit into from Jan 2, 2019
Merged

stdenv/native: add missing argument to fix build failure #53219

merged 1 commit into from Jan 2, 2019

Conversation

andrew-d
Copy link
Contributor

@andrew-d andrew-d commented Jan 2, 2019

Motivation for this change

Adds missing crossOverlays argument to the native stdenv. This fixes a build error when trying to do something like:

nixpkgs.localSystem = {
  system = "armv7l-linux";
  config = "armv7a-unknown-linux-gnueabihf";
  inherit platform;
};

I ran into this while trying to override the platform for an armv7l board to change the FPU; I get an error about an invalid argument without this patch.

Related to #48803

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

r? @matthewbauer (original PR)

@matthewbauer
Copy link
Member

Thanks! Sorry for missing that in the original pr.

@matthewbauer matthewbauer merged commit 82f679c into NixOS:master Jan 2, 2019
@andrew-d
Copy link
Contributor Author

andrew-d commented Jan 2, 2019 via email

@matthewbauer
Copy link
Member

matthewbauer commented Jan 2, 2019 via email

@andrew-d
Copy link
Contributor Author

andrew-d commented Jan 2, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrew-d @matthewbauer @GrahamcOfBorg