Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xkb-switch: 1.3.1 -> 1.5.0 #53213

Closed
wants to merge 1 commit into from
Closed

xkb-switch: 1.3.1 -> 1.5.0 #53213

wants to merge 1 commit into from

Conversation

wedens
Copy link

@wedens wedens commented Jan 2, 2019

Motivation for this change

Update xkb-switch to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build xkb-switch

@wedens
Copy link
Author

wedens commented Jan 3, 2019

I've replaced hash with a tag and renamed xkb_switch to xkb-switch in all-packages.nix.

@worldofpeace
Copy link
Contributor

Merged in 88a82a4

Just had to rename another reference to xkb_switch in vimPlugins.

@worldofpeace
Copy link
Contributor

@wedens Thanks for your contribution ✨

@wedens wedens deleted the xkb-switch-bump branch January 3, 2019 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wedens @worldofpeace @GrahamcOfBorg