Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: fix sha256 for 72.0.3626.121 #57003

Merged
merged 1 commit into from
Mar 7, 2019
Merged

chromium: fix sha256 for 72.0.3626.121 #57003

merged 1 commit into from
Mar 7, 2019
+1 −1

Conversation

ivan
Copy link
Member

@ivan ivan commented Mar 7, 2019 •
edited
Loading

Motivation for this change

The sha256 was previously unchanged from 72.0.3626.119.

Fixes #56998.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

72.0.3626.121 (for real now) is running fine here.

Sorry, something went wrong.

@ivan
chromium: fix sha256 for 72.0.3626.121
2129c6e 
The sha256 was previously unchanged from 72.0.3626.119
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 7, 2019
@grahamc
Copy link
Member

grahamc commented Mar 7, 2019

@GrahamcOfBorg build chromium.src

@ivan
Copy link
Member Author

ivan commented Mar 7, 2019 •
edited
Loading

Updated description to reflect that .121 does build and run here (and reports the correct version).

@infinisil infinisil merged commit 992364d into NixOS:master Mar 7, 2019
@infinisil
Copy link
Member

Cherrypicked to release-19.03 in 2e6b8b3 and to release-18.09 in 7e34b17

adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
Merge pull request NixOS#57003 from ivan/chromium-sha256
98889b7 
chromium: fix sha256 for 72.0.3626.121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ivan @grahamc @infinisil @GrahamcOfBorg