Skip to content

nixos/gnupg: set SSH_AUTH_SOCK in non-interactive settings #56254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2019
Merged

nixos/gnupg: set SSH_AUTH_SOCK in non-interactive settings #56254

merged 1 commit into from
Mar 8, 2019
+3 −1

Conversation

shosti
Copy link
Contributor

@shosti shosti commented Feb 23, 2019

SSH_AUTH_SOCK is useful in some non-interactive settings, for instance
daemonized Emacs. Fixes #55733.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@shosti
nixos/gnupg: set SSH_AUTH_SOCK in non-interactive settings
ddabdc0 
`SSH_AUTH_SOCK` is useful in some non-interactive settings, for instance
daemonized Emacs. Fixes NixOS#55733.
@shosti shosti requested a review from infinisil as a code owner February 23, 2019 18:51
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 23, 2019
@shosti shosti mentioned this pull request Feb 28, 2019
Closed
@shosti
Copy link
Contributor Author

shosti commented Mar 6, 2019

Hi! Any updates on this?

@infinisil infinisil merged commit 782cc91 into NixOS:master Mar 8, 2019
@infinisil
Copy link
Member

Looks good, thanks :)

@infinisil infinisil mentioned this pull request Apr 12, 2019
Closed
@infinisil
Copy link
Member

Backported to 19.03 in 8bb9a8a
Backport to 18.09 not needed

adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
Merge pull request NixOS#56254 from shosti/gnupg-ssh-austh-sock
948f9c6 
nixos/gnupg: set SSH_AUTH_SOCK in non-interactive settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emacs daemon doesn't see SSH_AUTH_SOCK from gnupg
3 participants
@shosti @infinisil @GrahamcOfBorg