Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coursier: update to 1.1.0-M13 #56914

Closed
wants to merge 2 commits into from
Closed

coursier: update to 1.1.0-M13 #56914

wants to merge 2 commits into from

Conversation

mebubo
Copy link
Contributor

@mebubo mebubo commented Mar 5, 2019

The download url changed because, according to
https://get-coursier.io/docs/cli-overview.html#curl:

For versions 1.1.0-M9 and later, the launcher is available as an
asset on the GitHub release page, e.g.
https://github.com/coursier/coursier/releases/download/v1.1.0-M9/coursier

(The old committed in-repo version has not been updated since M9)

The hash was generated by doing

$ curl -LO https://github.com/coursier/coursier/releases/download/v1.1.0-M13/coursier
$ nix hash-file coursier

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mebubo
coursier: update to 1.1.0-M13
046ee0c 
The download url changed because, according to
https://get-coursier.io/docs/cli-overview.html#curl:

> For versions 1.1.0-M9 and later, the launcher is available as an
> asset on the GitHub release page, e.g.
> https://github.com/coursier/coursier/releases/download/v1.1.0-M9/coursier

(The old committed in-repo version has not been updated since M9)

The hash was generated by doing

$ curl -LO https://github.com/coursier/coursier/releases/download/v1.1.0-M13/coursier
$ nix hash-file coursier
@mebubo
coursier: use the older hash format
ec7c5ec 
grahamcofborg-eval is not happy with the new one.

Obtained via

$ curl -LO https://github.com/coursier/coursier/releases/download/v1.1.0-M13/coursier
$ nix-hash --type sha256 --base32 coursier
@mebubo
Copy link
Contributor Author

mebubo commented Mar 6, 2019

Sorry, the latest version actually fails to build on my machine:

trying https://github.com/coursier/coursier/releases/download/v1.1.0-M13/coursier
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   598    0   598    0     0   1656      0 --:--:-- --:--:-- --:--:--  1656
100 18485  100 18485    0     0  18356      0  0:00:01  0:00:01 --:--:-- 65549
hash mismatch in fixed-output derivation '/nix/store/la9v390lfxal76jzgh81x7gw7kpwh6az-coursier':
  wanted: sha256:0szqgxf22nmqflpmj0inpcjyqmffpd4vrmgv186b85g15i7504mm
  got:    sha256:132zyfj9vxivz67901air4r7n0j1415dzj5z21ja8dh79r628fxs
cannot build derivation '/nix/store/w6k5hdnwqpg9f4swpmji1hnm49jfism8-coursier-1.1.0-M13.drv': 1 dependencies couldn't be built

Closing until I find what the correct way to specify hashes is.

@mebubo mebubo closed this Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mebubo @GrahamcOfBorg @Janik-Haag