Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spice-up: 1.7.0 -> 1.8.0 #56915

Merged
merged 1 commit into from Mar 5, 2019
Merged

spice-up: 1.7.0 -> 1.8.0 #56915

merged 1 commit into from Mar 5, 2019

Conversation

xiorcale
Copy link
Contributor

@xiorcale xiorcale commented Mar 5, 2019

Motivation for this change

Fix spice-up which didn't build on master and update to 1.8.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xiorcale xiorcale mentioned this pull request Mar 5, 2019
Closed
10 tasks
@worldofpeace worldofpeace merged commit 5b3507b into NixOS:master Mar 5, 2019
@worldofpeace
Copy link
Contributor

Thanks @Kjuvi for fixing this ❇️

@xiorcale xiorcale deleted the spice-up-update branch March 5, 2019 22:17
@worldofpeace
Copy link
Contributor

Backported in 8d9f70e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xiorcale @worldofpeace @GrahamcOfBorg