Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgui: 2.0.3 -> 2.1.0 (to fix build) #56999

Merged
merged 1 commit into from Mar 7, 2019
Merged

Conversation

knedlsepp
Copy link
Member

Motivation for this change

Hydra build was broken due to missing linking against the math library. Could have been fixed by adding NIX_LDFLAGS=-lm, but upgrading the package also solved it.
Please backport to 19.03.
ZHF-19.03: #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knedlsepp knedlsepp changed the title cgui: 2.0.3 -> 2.1.0 cgui: 2.0.3 -> 2.1.0 (to fix build) Mar 6, 2019
@7c6f434c 7c6f434c merged commit 80d032b into NixOS:master Mar 7, 2019
7c6f434c added a commit that referenced this pull request Mar 7, 2019
cgui: 2.0.3 -> 2.1.0 (to fix build)
(cherry picked from commit 80d032b)
@7c6f434c
Copy link
Member

7c6f434c commented Mar 7, 2019

dd1f371

@knedlsepp
Copy link
Member Author

Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants