zsh-git-prompt: switch to a new fork. #56996
Conversation
| sha256 = "19x1gf1r6l7r6i7vhhsgzcbdlnr648jx8j84nk2zv1b8igh205hw"; | ||
| url = "https://github.com/starcraftman/zsh-git-prompt.git"; | ||
| rev = "11b83ba3b85d14c66cf2ab79faefab6d838da28e"; | ||
| sha256 = "04aylsjfb03ckw219plkzpyiq4j9g66bjxa5pa56h1p7df6pjssb"; |
There was a problem hiding this comment.
Can you switch this to fetchFromGitHub?
There was a problem hiding this comment.
Done!
I also changed the version to reflect the fact that the fork hasn't actually released a 0.5 version yet (see starcraftman/zsh-git-prompt#38)
|
Oh, next time you should format your commit messages according to the Contribution Guidelines, also linked to from the PR template. |
|
Do you mean about the second commit? (Although I see I left a period at the end of the first commit, so, noted.) What should one do for subsequent commits? Repeating the package name and summary of the PR in every commit seems unhelpful? (But happy to do that if that's the convention, of course.) Or should you squash everything to do with one Nix component into one commit? |
|
(Also, thanks!) |
|
It's so that in the big |
|
Ahhh, that makes sense. Thanks! Will do. |
Motivation for this change
The git repo this package is based on has been left unmaintained for some years. Based on a thread in that repo, a new(-ish) fork seems to have emerged with fixes and ongoing maintainership. I found this while looking for solutions to issues I was seeing with the existing package, and this solved them all for me.
I propose we switch our package to point to this fork instead. I have been using this change for the last week or so and found it generally works well. Wider testing is probably needed(!)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)