Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome-keysign: init at 1.0.1 #57000

Merged
merged 1 commit into from Sep 8, 2019
Merged

gnome-keysign: init at 1.0.1 #57000

merged 1 commit into from Sep 8, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 6, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar added this to To Do in GNOME Mar 6, 2019
worldofpeace
worldofpeace suggested changes Mar 7, 2019
View reviewed changes
pkgs/tools/security/gnome-keysign/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/gnome-keysign/default.nix Outdated Show resolved Hide resolved
@jtojnar jtojnar marked this pull request as ready for review September 3, 2019 16:51
@jtojnar jtojnar merged commit 98d9589 into NixOS:master Sep 8, 2019
GNOME automation moved this from To Do to Done Sep 8, 2019
@jtojnar jtojnar deleted the gnome-keysign branch September 8, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
GNOME
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @worldofpeace @GrahamcOfBorg