Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solc: 0.5.4 -> 0.5.7 #56937

Merged
merged 3 commits into from Apr 7, 2019
Merged

solc: 0.5.4 -> 0.5.7 #56937

merged 3 commits into from Apr 7, 2019

Conversation

AtkinsChang
Copy link
Contributor

@AtkinsChang AtkinsChang commented Mar 6, 2019 •
edited

Motivation for this change

Changelog.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AtkinsChang AtkinsChang changed the title solc: 0.5.4 -> 0.5.5 solc: 0.5.4 -> 0.5.6 Mar 14, 2019
@matthewbauer
Copy link
Member

@GrahamcOfBorg build solc

@AtkinsChang AtkinsChang changed the title solc: 0.5.4 -> 0.5.6 solc: 0.5.4 -> 0.5. Mar 27, 2019
@AtkinsChang AtkinsChang changed the title solc: 0.5.4 -> 0.5. solc: 0.5.4 -> 0.5.7 Mar 27, 2019
@AtkinsChang AtkinsChang changed the title solc: 0.5.4 -> 0.5.7 solc: 0.5.4 -> 0.5.6 Mar 27, 2019
@AtkinsChang AtkinsChang changed the title solc: 0.5.4 -> 0.5.6 solc: 0.5.4 -> 0.5.7 Mar 29, 2019
@timokau
Copy link
Member

timokau commented Apr 7, 2019

@GrahamcOfBorg build solc

timokau
timokau approved these changes Apr 7, 2019
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and welcome to the project :) 🎉

@timokau timokau merged commit 940679a into NixOS:master Apr 7, 2019
@AtkinsChang AtkinsChang deleted the solc-0.5.5 branch August 8, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AtkinsChang @matthewbauer @timokau @infinisil @GrahamcOfBorg @Janik-Haag