Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustup: 1.16.0 -> 1.17.0 #57019

Merged
merged 1 commit into from Mar 7, 2019
Merged

rustup: 1.16.0 -> 1.17.0 #57019

merged 1 commit into from Mar 7, 2019

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Mar 7, 2019

changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg requested a review from Mic92 March 7, 2019 12:20
andir
andir reviewed Mar 7, 2019
View reviewed changes
pkgs/development/tools/rust/rustup/default.nix
@@ -37,7 +37,11 @@ rustPlatform.buildRustPackage rec {
postInstall = ''
pushd $out/bin
mv rustup-init rustup
for link in cargo rustc rustdoc rust-gdb rust-lldb rls rustfmt cargo-fmt cargo-clippy; do
binlinks=(
cargo rustc rustdoc rust-gdb rust-lldb rls rustfmt cargo-fmt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a nice way to check if we are missing a (new) link? I guess we might run into issues with future updates where new commands are being introduced that we didn't catch.

Copy link
Member

@Mic92 Mic92 Mar 7, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not anything related to this so far. Also we might want also include symlinks only available in nightly, so anything we can interfere from rustc.src might be out-dated.

@Mic92
Copy link
Member

Mic92 commented Mar 7, 2019

@GrahamcOfBorg build rustup

@Mic92 Mic92 merged commit f161478 into NixOS:master Mar 7, 2019
@dywedir dywedir deleted the rustup branch March 9, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir left review comments

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dywedir @Mic92 @andir @GrahamcOfBorg