Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildLuarocksPackage: adjust the manifest path #57060

Merged
merged 1 commit into from Mar 8, 2019

Conversation

teto
Copy link
Member

@teto teto commented Mar 8, 2019

the new luarocks 3.0.4 uses different paths for the manifests, hence creating new collisions.

Motivation for this change

fixes #57043

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

the new luarocks 3.0.4 uses different paths for the manifests, hence creating new collisions.
@peterhoeg
Copy link
Member

We need this in 19.03 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

neovim fails to build since Luarocks update
4 participants