Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmus: add mpris support on linux #57004

Merged
merged 1 commit into from
Mar 8, 2019
Merged

cmus: add mpris support on linux #57004

merged 1 commit into from
Mar 8, 2019
+2 −0

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Mar 7, 2019

Motivation for this change

#56813

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@aanderse
Copy link
Member Author

aanderse commented Mar 7, 2019

@GrahamcOfBorg build cmus

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 7, 2019
@aanderse
Copy link
Member Author

aanderse commented Mar 7, 2019

ping @oxij as the listed maintainer.

@oxij
Copy link
Member

oxij commented Mar 7, 2019 via email

@oxij
Copy link
Member

oxij commented Mar 7, 2019 via email

@aanderse
Copy link
Member Author

aanderse commented Mar 7, 2019 •
edited
Loading

@oxij Looks like systemd from the Makefile: https://github.com/cmus/cmus/blob/967a470b31ed2e6fc737ae523ba24b4dfdf81595/Makefile#L25

No need to make optional as systemd is a hard dependency on Linux.

@aanderse aanderse changed the title cmus: added mpris support on linux cmus: add mpris support on linux Mar 7, 2019
@oxij
Copy link
Member

oxij commented Mar 7, 2019 via email

@aanderse
Copy link
Member Author

aanderse commented Mar 7, 2019

Good point.

My understanding of MPRIS was also that the communication happened over dbus, but again it looks like you can (and cmus does) use libsystemd: https://github.com/cmus/cmus/blob/483d1862ed023c3e00f2c8c4e71da40022af2f78/configure#L584

I've made the dependency optional via mprisSupport and cleaned up a bit. How does this look to you?

@oxij
Copy link
Member

oxij commented Mar 8, 2019 via email

@Mic92
Copy link
Member

Mic92 commented Mar 8, 2019

@GrahamcOfBorg build cmus

@aanderse
Copy link
Member Author

aanderse commented Mar 8, 2019 •
edited
Loading

cmus was already not building on darwin it appears: https://hydra.nixos.org/eval/1508607?filter=cmus&compare=1508574&full=#tabs-still-fail

@Mic92 Look good to merge?

@7c6f434c 7c6f434c merged commit 7788f71 into NixOS:master Mar 8, 2019
@aanderse aanderse deleted the cmus branch March 8, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aanderse @oxij @Mic92 @7c6f434c @GrahamcOfBorg