Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.pplpy: init at 0.8.4 #56911

Closed
wants to merge 2 commits into from
Closed

Conversation

timokau
Copy link
Member

@timokau timokau commented Mar 5, 2019

Motivation for this change

This package depends on a newer version (alpha) of gmpy2, which has significant changes (including a cython interface).
I've copied the way shpinx adds multiple versions in python-packages.nix. I'm not sure if that is the right way to do it. @FRidh @domenkozar?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This didn't cause issues earlier since all packages that depend on
cysignals have a pari dependency anyways.
@timokau timokau requested a review from FRidh as a code owner March 5, 2019 21:03
This is a new dependency for the upcoming sage version.
@@ -1877,6 +1879,18 @@ in {

gmpy2 = callPackage ../development/python-modules/gmpy2 { };

# alpha release, big refactor, adds cython support
# see https://github.com/aleaxit/gmpy/issues/146, https://github.com/aleaxit/gmpy/issues/199
gmpy2_2_1 = (callPackage ../development/python-modules/gmpy2 {}).overridePythonAttrs (oldAttrs: rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do that for Python packages because having different versions of the same package in $PYTHONPATH is not supported. You could upgrade the default gmpy2 instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I don't see a specific version requirement for gmpy2 in pplpy's setup.py.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Their readme specifies

gmpy2: version 2.1.0a4 from sources

There is a beta release coming probably soonish (aleaxit/gmpy#199), so maybe upgrading after that makes sense.

(I meant to ping you in the PR, not domenkozar. Damn autocomplete)

@timokau timokau mentioned this pull request Apr 9, 2019
10 tasks
@timokau
Copy link
Member Author

timokau commented Apr 12, 2019

I'll include this in #54690.

@timokau timokau closed this Apr 12, 2019
@timokau timokau deleted the pplpy-init branch April 12, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants