Skip to content

vscode: 1.31.1 -> 1.32.0 #57047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2019
Merged

vscode: 1.31.1 -> 1.32.0 #57047

merged 1 commit into from
Mar 7, 2019
+4 −4

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Mar 7, 2019

Motivation for this change

As usual, only tested x86_64.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@eadwu
vscode: 1.31.1 -> 1.32.0

Verified

This commit was signed with the committer’s verified signature.
eadwu Edmund Wu
GPG key ID: 9C0561D4193A3AFE
Verified
Learn about vigilant mode
2a0d01f
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 7, 2019
worldofpeace
worldofpeace approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and executes on NixOS, and I've verified all the hashes.

@worldofpeace worldofpeace merged commit 9c88a41 into NixOS:master Mar 7, 2019
@worldofpeace
Copy link
Contributor

I'm going to now backport this to 18.09 and 19.03.

This will probably be the last backport on 18.09 for this package.

@worldofpeace
Copy link
Contributor

Backported in

@eadwu eadwu deleted the vscode/1.32.0 branch November 17, 2020 23:34
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
Merge pull request NixOS#57047 from eadwu/vscode/1.32.0
3908391 
vscode: 1.31.1 -> 1.32.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @worldofpeace @GrahamcOfBorg