Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rPackages.phytools: fix installation #56946

Merged
merged 1 commit into from Mar 6, 2019
Merged

Conversation

iimog
Copy link
Member

@iimog iimog commented Mar 6, 2019

Motivation for this change

Installation of rPackages.phytools fails using the current master branch of NixOS/nixpkgs (18.09-beta-20444-g66d5e3e4d56). As reported in #55418 the cause of the error is the missing buildInput pkgs.which.

This pull request fixes #55418

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@iimog iimog requested a review from peti as a code owner March 6, 2019 10:46
@peti peti merged commit c3944ac into NixOS:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error installing rPackages.phytools
2 participants