Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubber: fix build #56928

Merged
merged 1 commit into from Mar 6, 2019
Merged

rubber: fix build #56928

merged 1 commit into from Mar 6, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

propagatedBuildInputs -> nativeBuildInputs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg merged commit ed3caf3 into NixOS:master Mar 6, 2019
@peterhoeg peterhoeg deleted the f/rubber branch March 6, 2019 00:11
@peterhoeg peterhoeg restored the f/rubber branch March 6, 2019 00:56
@peterhoeg peterhoeg deleted the f/rubber branch March 18, 2019 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @GrahamcOfBorg