Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protonmail-bridge: 1.1.1-1 -> 1.1.3-1 #56926

Merged
merged 1 commit into from Mar 8, 2019
Merged

protonmail-bridge: 1.1.1-1 -> 1.1.3-1 #56926

merged 1 commit into from Mar 8, 2019

Conversation

aaronjanse
Copy link
Member

@aaronjanse aaronjanse commented Mar 5, 2019 •
edited

Motivation for this change

Fixes MIME for sending messages. I don't know how to see the changelog again after closing the dialog, but I know the bugfixes included MIME.

With this change, I can now send emails from the Geary email client.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ciil
ciil suggested changes Mar 7, 2019
View reviewed changes
Copy link
Member

@ciil ciil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works, but could you add something like ln -s $out/lib/protonmail-bridge $out/bin/Desktop-Bridge for backwards compatibility?

@GRBurst
Copy link
Contributor

GRBurst commented Mar 7, 2019 •
edited

Tested and works, but could you add something like ln -s $out/lib/protonmail-bridge $out/bin/Desktop-Bridge for backwards compatibility?

Although backwards compatibility is generally advantageous, this often introduces unnecessary problems.
By time, it becomes harder to remove such links because users depend on that link, so removing it later is much more problematic.
Also people forget whether this code (or link) is necessary or just based on a cosmetic decision.

Therefore, I suggest to make a clean cut. I think that it is a minor problem currently.

@ciil
Copy link
Member

ciil commented Mar 7, 2019

@GRBurst I'm okay with that as well, we should just be aware of the potential problems.

@Mic92 Mic92 merged commit 3465f3a into NixOS:master Mar 8, 2019
@Mic92
Copy link
Member

Mic92 commented Mar 8, 2019

Also backport to 19.03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeyroux apeyroux apeyroux approved these changes

@ciil ciil ciil approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aaronjanse @GRBurst @ciil @Mic92 @apeyroux @GrahamcOfBorg