Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcompris: fix build #56929

Merged
merged 1 commit into from Mar 7, 2019
Merged

gcompris: fix build #56929

merged 1 commit into from Mar 7, 2019

Conversation

stephengroat
Copy link
Contributor

Motivation for this change

Fix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nlewo
Copy link
Member

nlewo commented Mar 6, 2019

@GrahamcOfBorg build gcompris
@stephengroat what was the issue? It didn't build or failed at runtime?

@stephengroat
Copy link
Contributor Author

stephengroat commented Mar 6, 2019 •
edited

@nlewo sorry about forgetting to add that detail, fixing a build https://hydra.nixos.org/build/89537355/nixlog/1

@nlewo nlewo merged commit 76c1685 into NixOS:master Mar 7, 2019
@nlewo
Copy link
Member

nlewo commented Mar 7, 2019

@stephengroat Thanks

Backported on 19.03 in 4743d8d

@stephengroat stephengroat deleted the patch-4 branch March 7, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephengroat @nlewo @GrahamcOfBorg