Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shelldap: init at 1.4.0 #56933

Merged
merged 3 commits into from Jun 12, 2019
Merged

shelldap: init at 1.4.0 #56933

merged 3 commits into from Jun 12, 2019

Conversation

tobiasBora
Copy link
Contributor

@tobiasBora tobiasBora commented Mar 6, 2019 •
edited by kalbasit

Motivation for this change

Integrate the tool shelldap (that let you browse in shelldap like in a shell).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

kalbasit
kalbasit requested changes Mar 6, 2019
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
@kalbasit
Copy link
Member

kalbasit commented Mar 6, 2019

@GrahamcOfBorg build shelldap perlPackages.TermShell

@kalbasit
Copy link
Member

kalbasit commented Mar 9, 2019

@GrahamcOfBorg build shelldap

@kalbasit
Copy link
Member

kalbasit commented Mar 9, 2019

Darwin build is failing:

ld: unknown option: -mmacosx-version-min=10.10
Couldn't execute ld HASCOMPILERhT0p/TESTHrUY.o -o HASCOMPILERhT0p/TESTHrUY.bundle  -mmacosx-version-min=10.10 -bundle -undefined dynamic_lookup -L/no-such-path/lib -fstack-protector-strong : Inappropriate ioctl for device at Makefile.PL line 8.
Sorry! YAML::Syck requires a compiler in order to be built.

@LnL7 thoughts on why it's failing?

@tobiasBora
Copy link
Contributor Author

@kalbasit : It still does not compile? Any idea how I can at least try to compile it on mac as I don't have a mac? Or maybe we can first just use it for linux only?

@tobiasBora
Copy link
Contributor Author

@GrahamcOfBorg build shelldap

@kalbasit
Copy link
Member

Not sure how to make this work for Mac. You'll have to debug on a Mac machine. Can you scope to Linux only for now so we can get it merged?

peterhoeg
peterhoeg requested changes May 28, 2019
View reviewed changes
pkgs/tools/misc/shelldap/default.nix Show resolved Hide resolved
pkgs/tools/misc/shelldap/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/shelldap/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/perl-packages.nix Outdated
};
buildInputs = [ ModuleBuild ];
propagatedBuildInputs = [ TermReadKey TextAutoformat ];
meta = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with stdenv.lib

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added with stdenv.lib, and removed the ModuleBuild (even if I think cpan2nix added it for me, but not sure anymore). Thanks!

@tobiasBora tobiasBora force-pushed the master branch 2 times, most recently from 1e5a310 to 25cbc08 Compare June 5, 2019 23:48
@tobiasBora
Copy link
Contributor Author

Ok, so I disabled the compilation for mac as I don't have any mac to test, and I applied the change requested. It should build now.

@kalbasit
Copy link
Member

@GrahamcOfBorg build shelldap perlPackages.TermShell

@kalbasit kalbasit merged commit 6f4578a into NixOS:master Jun 12, 2019
@clerie clerie mentioned this pull request Sep 29, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

@peterhoeg peterhoeg peterhoeg requested changes

@aanderse aanderse aanderse left review comments

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tobiasBora @kalbasit @grahamc @peterhoeg @aanderse @GrahamcOfBorg