Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sewer: Fix build #56981

Merged
merged 2 commits into from Mar 7, 2019
Merged

sewer: Fix build #56981

merged 2 commits into from Mar 7, 2019

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This fixes sewer. Please backport to 19.03.
ZHF-19.03: #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The sed expression actually caused an error on hydra:
```
sed: -e expression NixOS#1, char 18: Invalid collation character
```
It seems to build fine without it however.
@knedlsepp
Copy link
Member Author

@GrahamcOfBorg build sewer

@markuskowa markuskowa merged commit dd60cca into NixOS:master Mar 7, 2019
@markuskowa
Copy link
Member

Backported to 19.03 via 82a3ab0 and 939abef

@knedlsepp
Copy link
Member Author

Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants