Skip to content

sewer: Fix build #56981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2019
Merged

sewer: Fix build #56981

merged 2 commits into from
Mar 7, 2019
+2 −7

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This fixes sewer. Please backport to 19.03.
ZHF-19.03: #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

knedlsepp added 2 commits March 6, 2019 21:11
@knedlsepp
sewer: Fix build

Verified

This commit was signed with the committer’s verified signature.
zimbatm Jonas Chevalier
GPG key ID: 71BAF6D40C1D63D7
Verified
Learn about vigilant mode
19fc5cb 
The sed expression actually caused an error on hydra:
```
sed: -e expression #1, char 18: Invalid collation character
```
It seems to build fine without it however.
@knedlsepp
sewer: 0.6.0 -> 0.7.0
841beaf
@knedlsepp
Copy link
Member Author

@GrahamcOfBorg build sewer

@knedlsepp knedlsepp changed the title Fix sewer sewer: Fix build Mar 6, 2019
@GrahamcOfBorg GrahamcOfBorg requested a review from kevincox March 6, 2019 20:49
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 6, 2019
@markuskowa markuskowa merged commit dd60cca into NixOS:master Mar 7, 2019
@markuskowa
Copy link
Member

Backported to 19.03 via 82a3ab0 and 939abef

@knedlsepp
Copy link
Member Author

Thx.

adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
Merge pull request NixOS#56981 from knedlsepp/fix-sewer
00e8890 
sewer: Fix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincox kevincox

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@knedlsepp @markuskowa @kevincox @GrahamcOfBorg