Skip to content

nixos/openldap: Fix quoting of log level #57020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2019
Merged

nixos/openldap: Fix quoting of log level #57020

merged 1 commit into from
Mar 7, 2019

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Mar 7, 2019

Motivation for this change

You cannot specify multiple log levels right now (like acl trace).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 7, 2019
@bjornfor bjornfor merged commit 2a6f518 into NixOS:master Mar 7, 2019
@bjornfor
Copy link
Contributor

bjornfor commented Mar 7, 2019

Hm, I just tested passing -d "acl trace" and slapd said

unrecognized log level "acl trace"

Where is it documented that it should be able to take string values like that, like the nixos module example says?

@bjornfor
Copy link
Contributor

bjornfor commented Mar 7, 2019

Ah, I think the CLI option only takes one word, but it can be passed multiple times: -d acl -d trace. Perhaps the multiple loglevels can be set at once in the config file.

Then to really make the loglevel setting correct, either we should make it a list of strings, or set the loglevel option in the config file rather than on the command-line.

@bjornfor
Copy link
Contributor

bjornfor commented Mar 7, 2019

Where is it documented that it should be able to take string values like that, like the nixos module example says?

man slapd, man slapd.conf.

@bjornfor
Copy link
Contributor

bjornfor commented Mar 7, 2019

After reading a bit more, I think the point of the original "-d 0" argument in the nixos module was just to prevent slapd from forking. slapd loglevels are bitfields, so the -d 0 is really a NOP wrt. logging.

@infinisil
Copy link
Member

infinisil commented Mar 8, 2019

Btw, there's lib.escapeShellArg you could've used instead, which also escapes ' properly

@dasJ dasJ deleted the slapd-loglevel branch February 5, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants