Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/auto-upgrade: enable service only when it's enabled in options #56948

Merged
merged 2 commits into from Mar 7, 2019
Merged

nixos/auto-upgrade: enable service only when it's enabled in options #56948

merged 2 commits into from Mar 7, 2019

Conversation

danbst
Copy link
Contributor

@danbst danbst commented Mar 6, 2019 •
edited

Motivation for this change

This reduced closure size of tinyContainer from 449 MB to 403 MB

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danbst
nixos/auto-upgrade: enable service only when it's enabled in options
ff2bc96 
This reduced closure size of `tinyContainer` from 449 MB to 403 MB
@danbst danbst requested a review from infinisil as a code owner March 6, 2019 11:47
@infinisil
Copy link
Member

Can remove the condition on line 87 then

@danbst
Copy link
Contributor Author

danbst commented Mar 7, 2019

@infinisil thanks!

@danbst danbst merged commit af5909a into NixOS:master Mar 7, 2019
@danbst danbst deleted the auto-upgrade-fix branch March 7, 2019 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: closure-size 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danbst @infinisil @GrahamcOfBorg