Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for charLength field in SpeechSynthesisEvent-constructor #15732

Merged
merged 1 commit into from Mar 15, 2019

Conversation

sjdallst
Copy link
Contributor

@sjdallst sjdallst commented Mar 7, 2019

Here's the PR for adding this attribute to the w3c spec.

foolip
foolip previously approved these changes Mar 13, 2019
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll merge together with the spec PR when that's done.

@foolip
Copy link
Member

foolip commented Mar 14, 2019

After the nullability has been settled in WICG/speech-api#50 this will need some changes.

@foolip foolip merged commit 3531dc2 into web-platform-tests:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants