Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tayga: init at 0.9.2 #57048

Merged
merged 1 commit into from Mar 19, 2019
Merged

tayga: init at 0.9.2 #57048

merged 1 commit into from Mar 19, 2019

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Mar 7, 2019

Motivation for this change

tayga

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Mar 8, 2019

@GrahamcOfBorg eval

@veprbl
Copy link
Member

veprbl commented Mar 8, 2019

@GrahamcOfBorg build tayga

@0x4A6F 0x4A6F marked this pull request as ready for review March 13, 2019 18:21
ryantm
ryantm requested changes Mar 15, 2019
View reviewed changes
pkgs/tools/networking/tayga/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/tayga/default.nix Outdated Show resolved Hide resolved
@ryantm
Copy link
Member

ryantm commented Mar 15, 2019

@GrahamcOfBorg build tayga

@0x4A6F
Copy link
Member Author

0x4A6F commented Mar 15, 2019

Thanks @ryantm

@veprbl
Copy link
Member

veprbl commented Mar 15, 2019

@GrahamcOfBorg build tayga

@ryantm
Copy link
Member

ryantm commented Mar 18, 2019

@GrahamcOfBorg build tayga

ryantm
ryantm previously approved these changes Mar 18, 2019
View reviewed changes
@ryantm ryantm dismissed their stale review March 18, 2019 18:46

Veprbl pointed out a needed fix

@veprbl veprbl merged commit 631ec69 into NixOS:master Mar 19, 2019
@veprbl
Copy link
Member

veprbl commented Mar 19, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@veprbl veprbl veprbl left review comments

@symphorien symphorien symphorien left review comments

@ryantm ryantm ryantm left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@0x4A6F @veprbl @ryantm @Mic92 @symphorien @GrahamcOfBorg