Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyhocon: init at 0.3.51 #57025

Merged
merged 4 commits into from Mar 24, 2019
Merged

pythonPackages.pyhocon: init at 0.3.51 #57025

merged 4 commits into from Mar 24, 2019

Conversation

chreekat
Copy link
Contributor

@chreekat chreekat commented Mar 7, 2019 •
edited

Motivation for this change

Add pyhocon package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@chreekat chreekat requested a review from FRidh as a code owner March 7, 2019 14:25
@FRidh
Copy link
Member

FRidh commented Mar 7, 2019

@GrahamcOfBorg build python3.pkgs.pyhocon python2.pkgs.pyhocon

@chreekat
Copy link
Contributor Author

My patch to make tests possible has been merged upstream, but not released to PyPi yet.

dotlambda
dotlambda requested changes Mar 23, 2019
View reviewed changes
pkgs/development/python-modules/pyhocon/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyhocon/default.nix Outdated
meta = with lib; {
homepage = https://github.com/chimpler/pyhocon/;
description = "HOCON parser for Python";
# Long description copied from <GitHub>/setup.py on 2019-03-06.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Long description copied from <GitHub>/setup.py on 2019-03-06.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep this. Only slightly worse than no long description at all is a copy/pasted description with no reference cited. :) However, I don't like my shorthand, so I'll be more explicit.

pkgs/development/python-modules/pyhocon/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyhocon/default.nix Outdated Show resolved Hide resolved
dotlambda and others added 3 commits March 24, 2019 14:28
@dotlambda @chreekat
Remove explicit dep on setuptools
8260a1d 
Per PR review.

Co-Authored-By: chreekat <b@chreekat.net>
@dotlambda @chreekat
Improve style formatting
e068247 
Co-Authored-By: chreekat <b@chreekat.net>
@chreekat
Be more specific with description reference
bfdf02c
@chreekat
Copy link
Contributor Author

Thanks for the review 👍

@dotlambda dotlambda changed the title pyhocon: init at version 0.3.51 pythonPackages.pyhocon: init at 0.3.51 Mar 24, 2019
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pyhocon python3.pkgs.pyhocon

@dotlambda dotlambda merged commit a30bed5 into NixOS:master Mar 24, 2019
@chreekat chreekat deleted the init-pyhocon branch March 24, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chreekat @FRidh @dotlambda @GrahamcOfBorg