Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift: 4.2.2 -> 4.2.3 #57024

Merged
merged 1 commit into from Mar 7, 2019
Merged

swift: 4.2.2 -> 4.2.3 #57024

merged 1 commit into from Mar 7, 2019

Conversation

mroi
Copy link
Contributor

@mroi mroi commented Mar 7, 2019

Update Swift to current version 4.2.3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member

dtzWill commented Mar 7, 2019

changes: https://forums.swift.org/t/swift-4-2-3/21089

LGTM, building now ... :)

@dtzWill dtzWill merged commit fe04378 into NixOS:master Mar 7, 2019
@mroi mroi deleted the patch-1 branch April 29, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants