teensyduino: 1.40 -> 1.45 #56936
Merged
teensyduino: 1.40 -> 1.45 #56936
+38
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps teensyduino version, simplifies building, and fixes a build error
|
Per #33147, the additional source is not necessary if this is compiled with jdk 8u144, but adding in an override for the JDK version seems much more complex. |
GrahamcOfBorg
added
10.rebuild-darwin: 0
|
I don't have an x86 system to test, but it's entirely possible that this fixes https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/arduino/arduino-core/default.nix#L12 |
bjornfor
approved these changes
Mar 6, 2019
Janik-Haag
added
the
12. first-time contribution
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
teensyduino: 1.40 -> 1.45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
On my system, teensyduino cannot build due to #33147
This resolves the issue by using jars from the officially distributed arduino package to get past the file size checks.
I also upgrade teensyduino to version 1.45, which removes the need to simulate clicks in an X server to perform the install.
Additionally, I add a variable to parameterize the teensyduino version.
These changes are more-or-less in line with that the Arch Linux PKGBUILD does, though their version relies purely on the distributed Arduino package, and does not build it from source.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)